Report the note when specified in diagnostic::on_unimplemented
#130123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nadrieril (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
requested changes
Sep 9, 2024
| @@ -0,0 +1,15 @@ | |||
| pub trait ProviderLt {} | |||
There was a problem hiding this comment.
This test doesn't really exercise anything. Could you please delete it?
| struct B; | ||
|
|
||
| fn main() { | ||
| B.request(); //~ ERROR 15:7: 15:14: my message [E0599] |
There was a problem hiding this comment.
Suggested change
| B.request(); //~ ERROR 15:7: 15:14: my message [E0599] | |
| B.request(); | |
| //~^ ERROR my message | |
| //~| LABEL my label | |
| //~| NOTE my note |
FedericoBruzzone
force-pushed
the
master
branch
from
7ffb12d
to
5168584
Compare
| @@ -1363,6 +1363,11 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| "the following trait bounds were not satisfied:\n{bound_list}" | |||
| )); | |||
| } | |||
| for note in notes { | |||
| debug!("FCB {}", note); | |||
There was a problem hiding this comment.
I beg your pardon, I had forgotten :'D
Comment on lines
14
to
19
| fn main() { | ||
| B.request(); | ||
| } | ||
| //~^^ my message [E0599] | ||
| //~| my label | ||
| //~| my note |
There was a problem hiding this comment.
Suggested change
| fn main() { | |
| B.request(); | |
| } | |
| //~^^ my message [E0599] | |
| //~| my label | |
| //~| my note | |
| fn main() { | |
| B.request(); | |
| //~^ my message | |
| //~| my label | |
| //~| my note | |
| } |
There was a problem hiding this comment.
Thank you. This is my first contribution, from the next I will learn best practices.
FedericoBruzzone
force-pushed
the
master
branch
2 times, most recently
from
b8ce945
to
252f8ec
Compare
|
@compiler-errors Thank you for your review. It should be okay now, let me know |
|
You still didn't delete the test file I asked to be deleted |
Signed-off-by: FedericoBruzzone <federico.bruzzone.i@gmail.com>
FedericoBruzzone
force-pushed
the
master
branch
from
252f8ec
to
4cecf42
Compare
I had deleted an incorrect file |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 11, 2024
…r-errors Report the `note` when specified in `diagnostic::on_unimplemented` Before this PR the `note` field was completely ignored for some reason, now it is shown (I think) correctly during the hir typechecking phase. 1. Report the `note` when specified in `diagnostic::on_unimplemented` 2. Added a test for unimplemented trait diagnostic 3. Added a test for custom unimplemented trait diagnostic Close rust-lang#130084 P.S. This is my first PR to rustc.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2024
…kingjubilee Rollup of 14 pull requests Successful merges: - rust-lang#129260 (Don't suggest adding return type for closures with default return type) - rust-lang#129520 (Suggest the correct pattern syntax on usage of unit variant pattern for a struct variant) - rust-lang#129696 (update stdarch) - rust-lang#129759 (Stabilize `const_refs_to_static`) - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86) - rust-lang#129866 (Clarify documentation labelling and definitions for std::collections) - rust-lang#130052 (Don't leave debug locations for constants sitting on the builder indefinitely) - rust-lang#130077 (Fix linking error when compiling for 32-bit watchOS) - rust-lang#130123 (Report the `note` when specified in `diagnostic::on_unimplemented`) - rust-lang#130156 (Add test for S_OBJNAME & update test for LF_BUILDINFO cl and cmd) - rust-lang#130206 (Map `WSAEDQUOT` to `ErrorKind::FilesystemQuotaExceeded`) - rust-lang#130207 (Map `ERROR_CANT_RESOLVE_FILENAME` to `ErrorKind::FilesystemLoop`) - rust-lang#130219 (Fix false positive with `missing_docs` and `#[test]`) - rust-lang#130221 (Make SearchPath::new public) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#129260 (Don't suggest adding return type for closures with default return type) - rust-lang#129520 (Suggest the correct pattern syntax on usage of unit variant pattern for a struct variant) - rust-lang#129866 (Clarify documentation labelling and definitions for std::collections) - rust-lang#130123 (Report the `note` when specified in `diagnostic::on_unimplemented`) - rust-lang#130161 (refactor merge base logic and fix `x fmt`) - rust-lang#130206 (Map `WSAEDQUOT` to `ErrorKind::FilesystemQuotaExceeded`) - rust-lang#130207 (Map `ERROR_CANT_RESOLVE_FILENAME` to `ErrorKind::FilesystemLoop`) - rust-lang#130219 (Fix false positive with `missing_docs` and `#[test]`) - rust-lang#130221 (Make SearchPath::new public) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2024
Rollup merge of rust-lang#130123 - FedericoBruzzone:master, r=compiler-errors Report the `note` when specified in `diagnostic::on_unimplemented` Before this PR the `note` field was completely ignored for some reason, now it is shown (I think) correctly during the hir typechecking phase. 1. Report the `note` when specified in `diagnostic::on_unimplemented` 2. Added a test for unimplemented trait diagnostic 3. Added a test for custom unimplemented trait diagnostic Close rust-lang#130084 P.S. This is my first PR to rustc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the
notefield was completely ignored for some reason, now it is shown (I think) correctly during the hir typechecking phase.notewhen specified indiagnostic::on_unimplementedClose #130084
P.S. This is my first PR to rustc.